chore: pass reply_builder explicitly to pubsub module #4021
+107
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, deprecate `reply_builder()` access method. Signed-off-by: Roman Gershman <[email protected]>
romange
commented
Oct 30, 2024
| @@ -137,61 +145,13 @@ void ConnectionContext::ChangeMonitor(bool start) { | |||
| EnableMonitoring(start); | |||
| } | |||
|
|
|||
| vector<unsigned> ChangeSubscriptions(bool pattern, CmdArgList args, bool to_add, bool to_reply, | |||
| ConnectionContext* conn) { | |||
There was a problem hiding this comment.
moved below to be a method of ConnectionContext
romange
commented
Oct 30, 2024
| @@ -21,6 +21,17 @@ namespace dfly { | |||
| using namespace std; | |||
| using namespace facade; | |||
|
|
|||
| static void SendSubscriptionChangedResponse(string_view action, std::optional<string_view> topic, | |||
There was a problem hiding this comment.
moved here from below
romange
commented
Nov 3, 2024
| @@ -269,6 +217,53 @@ size_t ConnectionContext::UsedMemory() const { | |||
| return facade::ConnectionContext::UsedMemory() + dfly::HeapSize(conn_state); | |||
| } | |||
|
|
|||
| vector<unsigned> ConnectionContext::ChangeSubscriptions(CmdArgList channels, bool pattern, | |||
| bool to_add, bool to_reply) { | |||
| vector<unsigned> result(to_reply ? channels.size() : 0, 0); | |||
There was a problem hiding this comment.
it was a free function, now it's a method.
adiholden
reviewed
Nov 4, 2024
| @@ -36,17 +36,10 @@ class ConnectionContext { | |||
| return protocol_; | |||
| } | |||
|
|
|||
| SinkReplyBuilder* reply_builder() { | |||
| SinkReplyBuilder* reply_builder_old() { | |||
There was a problem hiding this comment.
why do you called this _old?
There was a problem hiding this comment.
so that we won't use it. I will remove it in follow up PRs
adiholden
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, deprecate
reply_builder()access method.Finally, remove reply builder injection as its not needed anymore - we always pass this object via stack.